[PATCH] security: keys: trusted: Fix memory leaks on allocated blob

Jarkko Sakkinen jarkko at kernel.org
Tue Jul 27 03:05:57 UTC 2021


On Fri, Jul 23, 2021 at 06:21:21PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> There are several error return paths that don't kfree the allocated
> blob, leading to memory leaks. Ensure blob is initialized to null as
> some of the error return paths in function tpm2_key_decode do not
> change blob. Add an error return path to kfree blob and use this on
> the current leaky returns.
> 
> Addresses-Coverity: ("Resource leak")
> Fixes: f2219745250f ("security: keys: trusted: use ASN.1 TPM2 key format for the blobs")
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
 
Reviewed-by: Jarkko Sakkinen <jarkko at kernel.org>

Probably makes sense (for me) to add also

Cc: stable at vger.kernel.org

?

/Jarkko



More information about the Linux-security-module-archive mailing list