[PATCH 01/97] LSM: Infrastructure management of the superblock

[Casey Schaufler]

On 3/1/2019 6:02 AM, Edwin Zimmerman wrote:
> On Thursday2/28/2019 Casey Schaufler <casey at schaufler-ca.com> wrote:
>> From: Casey Schaufler <cschaufler at localhost.localdomain>
>>
>> Move management of the superblock->sb_security blob out
>> of the individual security modules and into the security
>> infrastructure. Instead of allocating the blobs from within
>> the modules the modules tell the infrastructure how much
>> space is required, and the space is allocated there.
>>
> ...
>> @@ -296,12 +297,13 @@ static void __init ordered_lsm_init(void)
>>   	for (lsm = ordered_lsms; *lsm; lsm++)
>>   		prepare_lsm(*lsm);
>>
>> -	init_debug("cred blob size     = %d\n", blob_sizes.lbs_cred);
>> -	init_debug("file blob size     = %d\n", blob_sizes.lbs_file);
>> -	init_debug("inode blob size    = %d\n", blob_sizes.lbs_inode);
>> -	init_debug("ipc blob size      = %d\n", blob_sizes.lbs_ipc);
>> -	init_debug("msg_msg blob size  = %d\n", blob_sizes.lbs_msg_msg);
>> -	init_debug("task blob size     = %d\n", blob_sizes.lbs_task);
>> +	init_debug("cred blob size       = %d\n", blob_sizes.lbs_cred);
>> +	init_debug("file blob size       = %d\n", blob_sizes.lbs_file);
>> +	init_debug("inode blob size      = %d\n", blob_sizes.lbs_inode);
>> +	init_debug("ipc blob size        = %d\n", blob_sizes.lbs_ipc);
>> +	init_debug("msg_msg blob size    = %d\n", blob_sizes.lbs_msg_msg);
>> +	init_debug("superblock blob size = %d\n", blob_sizes.lbs_superblock);
>> +	init_debug("task blob size       = %d\n", blob_sizes.lbs_task);
>>
> Any reason this couldn't be a single line, or am I missing something?

Indentation. If the preceding patches had gotten the indentation
right this would be the one line patch you suggest. To be fixed in
the next version.

> It took a second look to realize that the only line actually being added was
> +	init_debug("superblock blob size = %d\n", blob_sizes.lbs_superblock);
>
>