[PATCH] security: keys: remove redundant assignment to key_ref

David Howells dhowells at redhat.com
Wed Dec 6 14:50:17 UTC 2017

James Morris <james.l.morris at oracle.com> wrote:

> I think a general cleanup in that function to make all of these follow the 
> pattern:
> 	if (something) {
> 		key_ref = ERR_PTR(-error);
> 		goto error;
> 	}
> rather than unconditionally setting the error first, would be better, but 
> this is a clear enough fix on its own.

There's a preference in Linux to use:

	key_ref = ERR_PTR(-error);
 	if (something)
 		goto error;

instead because it uses less vertical space.  It might originally have been
promulgated by Linus, but I don't remember.  Though you do have a point - your
way makes error handling less subject breakage from code rearrangement.

To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

More information about the Linux-security-module-archive mailing list