[PATCH] security: keys: remove redundant assignment to key_ref

James Morris james.l.morris at oracle.com
Tue Dec 5 00:18:10 UTC 2017

On Mon, 4 Dec 2017, Colin King wrote:

> From: Colin Ian King <colin.king at canonical.com>
> Variable key_ref is being assigned a value that is never read;
> key_ref is being re-assigned a few statements later.  Hence this
> assignment is redundant and can be removed.
> Signed-off-by: Colin Ian King <colin.king at canonical.com>

I think a general cleanup in that function to make all of these follow the 

	if (something) {
		key_ref = ERR_PTR(-error);
		goto error;

rather than unconditionally setting the error first, would be better, but 
this is a clear enough fix on its own.

Reviewed-by: James Morris <james.l.morris at oracle.com>

James Morris
<james.l.morris at oracle.com>

To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

More information about the Linux-security-module-archive mailing list