[PATCH] keys: use long workqueue for garbage collection
Jarkko Sakkinen
jarkko at kernel.org
Sat Oct 24 05:43:49 UTC 2026
On Sat, Oct 24, 2026 at 08:37:42AM +0300, Jarkko Sakkinen wrote:
> On Sat, Oct 24, 2026 at 08:20:55AM +0300, Jarkko Sakkinen wrote:
> > On Sat, Oct 24, 2026 at 06:29:44AM +0200, Eduard Zateev wrote:
> > > The key garbage collector can wait for RCU grace periods. This can occupy a
> > > normal events worker for a long time and contribute to workqueue lockups.
> > >
> > > Queue key GC on system_long_wq because its work may wait for long periods.
> > >
> > > Reported-by: syzbot+c15de43f1e7fffbb7b9b at syzkaller.appspotmail.com
> > > Link: https://syzkaller.appspot.com/bug?extid=c15de43f1e7fffbb7b9b
> > > Signed-off-by: Eduard Zateev <hackerowskiy at gmail.com>
> >
> > This commit message is not huge selling point for any possible argument.
>
> You ignored key_gc_timed_out(), which leaves code to a broken state and
> switching workqueue is not solving any possible root cause of anything.
> The long queue exists mostly for the sake of flush_workqueue().
>
> Please stop sending patches like this in the future.
Makes me wonder was this even tried a single time TBH given the obvious
glitch. I would bet for no.
Br, Jarkko
More information about the Linux-security-module-archive
mailing list