[PATCH 26/27] selftests/landlock: Use EXPECT for closing FDs and stopping threads
sashiko-bot at kernel.org
sashiko-bot at kernel.org
Thu Oct 8 14:40:55 UTC 2026
> Closing FDs and cancelling or joining threads whose results are not
> used is teardown, whether it happens at the end of a test or in the
> middle of it. No later check depends on it, so a failure should be
> reported without aborting the test. Use EXPECT for these calls, as
> most tests already do. The same applies to removing the FIFO and
> reaping the child at the end of named_pipe_ioctl.
>
> The close(0) in ioctl_error() stays an ASSERT, as the following IOCTL
> relies on FD 0 being closed.
>
> Assisted-by: LLM
> Signed-off-by: Günther Noack <gnoack3000 at gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261008142604.39107-2-gnoack3000@gmail.com?part=26
More information about the Linux-security-module-archive
mailing list