[PATCH v4 09/19] landlock: Add create_domain and free_domain tracepoints

Günther Noack gnoack at google.com
Thu Aug 20 10:36:11 UTC 2026


On Tue, Aug 11, 2026 at 11:43:23AM +0200, Mickaël Salaün wrote:
> diff --git a/security/landlock/domain.c b/security/landlock/domain.c
> index d0b35ccce122..7651eee8fe02 100644
> --- a/security/landlock/domain.c
> +++ b/security/landlock/domain.c
> @@ -427,6 +426,7 @@ landlock_merge_ruleset(struct landlock_domain *const parent,
>  	int err;
>  
>  	might_sleep();
> +	lockdep_assert_held(&ruleset->lock);
>  	if (WARN_ON_ONCE(!ruleset))
>  		return ERR_PTR(-EINVAL);

This checks that ruleset is not NULL, but the newly added
lockdep_assert_held() line already dereferences it before.

—Günther




More information about the Linux-security-module-archive mailing list