[PATCH] keys: Replace memcpy with strscpy in proc_keys_show
Thorsten Blum
thorsten.blum at linux.dev
Wed Nov 12 17:26:21 UTC 2025
Use strscpy() to copy strings into the fixed-size buffer 'xbuf' instead
of hardcoding the number of bytes to copy. This improves maintainability
and ensures the buffer is always NUL-terminated.
Signed-off-by: Thorsten Blum <thorsten.blum at linux.dev>
---
security/keys/proc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/security/keys/proc.c b/security/keys/proc.c
index 4f4e2c1824f1..1d380766f45d 100644
--- a/security/keys/proc.c
+++ b/security/keys/proc.c
@@ -10,6 +10,7 @@
#include <linux/fs.h>
#include <linux/proc_fs.h>
#include <linux/seq_file.h>
+#include <linux/string.h>
#include <asm/errno.h>
#include "internal.h"
@@ -199,9 +200,9 @@ static int proc_keys_show(struct seq_file *m, void *v)
/* come up with a suitable timeout value */
expiry = READ_ONCE(key->expiry);
if (expiry == TIME64_MAX) {
- memcpy(xbuf, "perm", 5);
+ strscpy(xbuf, "perm");
} else if (now >= expiry) {
- memcpy(xbuf, "expd", 5);
+ strscpy(xbuf, "expd");
} else {
timo = expiry - now;
--
2.51.0
More information about the Linux-security-module-archive
mailing list