[PATCH] security: keys: Make sysctl table const
Jarkko Sakkinen
jarkko at kernel.org
Sat Mar 1 02:00:57 UTC 2025
On Thu, Feb 27, 2025 at 11:45:09AM -0500, Paul Moore wrote:
> On Thu, Feb 27, 2025 at 5:47 AM Ricardo B. Marlière <rbm at suse.com> wrote:
> > On Wed Feb 26, 2025 at 9:21 PM -03, Paul Moore wrote:
> > > On Thu, Jan 23, 2025 at 2:50 PM Ricardo B. Marliere
> > > <ricardo at marliere.net> wrote:
> > >>
> > >> Since commit 7abc9b53bd51 ("sysctl: allow registration of const struct
> > >> ctl_table"), the sysctl registration API allows for struct ctl_table to be
> > >> in read-only memory. Move key_sysctls to be declared at build time, instead
> > >> of having to be dynamically allocated at boot time.
> > >>
> > >> Cc: Thomas Weißschuh <linux at weissschuh.net>
> > >> Suggested-by: Thomas Weißschuh <linux at weissschuh.net>
> > >> Signed-off-by: Ricardo B. Marliere <rbm at suse.com>
> > >> ---
> > >> security/keys/sysctl.c | 2 +-
> > >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > Looks fine to me. David or Jarkko, this looks like something for the
> > > keys tree, yes?
> > >
> > > Reviewed-by: Paul Moore <paul at paul-moore.com>
> >
> > Thank you for the review, but I believe this has been done here:
> >
> > https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1751f872cc97f992ed5c4c72c55588db1f0021e1
>
> Even better :) Thanks for the update Ricardo.
+1
BR, Jarkko
More information about the Linux-security-module-archive
mailing list