[PATCH] smack: remove /smack/logging if audit is not configured

[Konstantin Andreev]

Casey Schaufler, 18 Jan 2025:
> On 1/17/2025 1:46 PM, Konstantin Andreev wrote:
>> If CONFIG_AUDIT is not set then
>> SMACK does not generate audit messages,
>> however, keeps audit control file, /smack/logging,
>> while there is no entity to control.
>> This change removes audit control file /smack/logging
>> when audit is not configured in the kernel
> 
> Is there a real reason to do this?

Not more real than there are real reasons for
fixing typos and spelling errors,
removing unused or duplicating code,
keeping one tab indentation, etc.

The matter of style.

Personally, I deprecate fake controls,
they make me (as a user) think that
it's me who is missing something.

> I can easily see systems that expect to turn logging off getting
> upset if the interface disappears seemingly at random.

To me, the system builder who compiles audit out, on purpose,
must be prepared for special treatment of his system.

Certainly, I may not have a full picture.
--
Regards,
Konstantin Andreev