[PATCH] security, fs, nfs, net: update security_inode_listsecurity() interface
Stephen Smalley
stephen.smalley.work at gmail.com
Mon Apr 28 16:23:17 UTC 2025
On Mon, Apr 28, 2025 at 12:17 PM Casey Schaufler <casey at schaufler-ca.com> wrote:
>
> On 4/28/2025 8:55 AM, Stephen Smalley wrote:
> > Update the security_inode_listsecurity() interface to allow
> > use of the xattr_list_one() helper and update the hook
> > implementations.
> >
> > Link: https://lore.kernel.org/selinux/20250424152822.2719-1-stephen.smalley.work@gmail.com/
> >
> > Signed-off-by: Stephen Smalley <stephen.smalley.work at gmail.com>
> > ---
> > This patch is relative to the one linked above, which in theory is on
> > vfs.fixes but doesn't appear to have been pushed when I looked.
>
> > diff --git a/include/linux/lsm_hook_defs.h b/include/linux/lsm_hook_defs.h
> > index bf3bbac4e02a..3c3919dcdebc 100644
> > --- a/include/linux/lsm_hook_defs.h
> > +++ b/include/linux/lsm_hook_defs.h
> > @@ -174,8 +174,8 @@ LSM_HOOK(int, -EOPNOTSUPP, inode_getsecurity, struct mnt_idmap *idmap,
> > struct inode *inode, const char *name, void **buffer, bool alloc)
> > LSM_HOOK(int, -EOPNOTSUPP, inode_setsecurity, struct inode *inode,
> > const char *name, const void *value, size_t size, int flags)
> > -LSM_HOOK(int, 0, inode_listsecurity, struct inode *inode, char *buffer,
> > - size_t buffer_size)
> > +LSM_HOOK(int, 0, inode_listsecurity, struct inode *inode, char **buffer,
> > + ssize_t *remaining_size)
>
> How about "rem", "rsize" or some other name instead of the overly long
> "remaining_size_"?
I don't especially care either way but was just being consistent with
the xattr_list_one() code.
More information about the Linux-security-module-archive
mailing list