[PATCH] selftests: lsm: Refactor `flags_overset_lsm_set_self_attr` test
Casey Schaufler
casey at schaufler-ca.com
Tue Nov 12 18:45:25 UTC 2024
On 11/12/2024 10:28 AM, Amit Vadhavana wrote:
> - Remove unnecessary `tctx` variable, use `ctx` directly.
> - Simplified code with no functional changes.
>
> Signed-off-by: Amit Vadhavana <av2082000 at gmail.com>
Reviewed-by: Casey Schaufler <casey at schaufler-ca.com>
> ---
> tools/testing/selftests/lsm/lsm_set_self_attr_test.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/lsm/lsm_set_self_attr_test.c b/tools/testing/selftests/lsm/lsm_set_self_attr_test.c
> index 66dec47e3ca3..732e89fe99c0 100644
> --- a/tools/testing/selftests/lsm/lsm_set_self_attr_test.c
> +++ b/tools/testing/selftests/lsm/lsm_set_self_attr_test.c
> @@ -56,16 +56,15 @@ TEST(flags_zero_lsm_set_self_attr)
> TEST(flags_overset_lsm_set_self_attr)
> {
> const long page_size = sysconf(_SC_PAGESIZE);
> - char *ctx = calloc(page_size, 1);
> + struct lsm_ctx *ctx = calloc(page_size, 1);
> __u32 size = page_size;
> - struct lsm_ctx *tctx = (struct lsm_ctx *)ctx;
>
> ASSERT_NE(NULL, ctx);
> if (attr_lsm_count()) {
> - ASSERT_LE(1, lsm_get_self_attr(LSM_ATTR_CURRENT, tctx, &size,
> + ASSERT_LE(1, lsm_get_self_attr(LSM_ATTR_CURRENT, ctx, &size,
> 0));
> }
> - ASSERT_EQ(-1, lsm_set_self_attr(LSM_ATTR_CURRENT | LSM_ATTR_PREV, tctx,
> + ASSERT_EQ(-1, lsm_set_self_attr(LSM_ATTR_CURRENT | LSM_ATTR_PREV, ctx,
> size, 0));
>
> free(ctx);
More information about the Linux-security-module-archive
mailing list