[PATCH] linux++: delete some forward declarations

Steven Rostedt rostedt at goodmis.org
Thu Jun 13 21:28:31 UTC 2024


On Thu, 13 Jun 2024 14:21:10 -0700
Andrew Morton <akpm at linux-foundation.org> wrote:

> On Thu, 13 Jun 2024 16:10:12 -0400 Steven Rostedt <rostedt at goodmis.org> wrote:
> 
> > > And...  I'm a bit surprised that forward declarations are allowed in C.
> > > A billion years ago I used a C compiler which would use 16 bits for
> > > an enum if the enumted values would fit in 16 bits.  And it would use 32
> > > bits otherwise.  So the enumerated values were *required* for the
> > > compiler to be able to figure out the sizeof.  But it was a billion
> > > years ago.  
> > 
> > Well, I only looked at the one change in ftrace.h which has a
> > "struct seq_file;" that is not used anywhere else in the file, so that
> > one definitely can go.  
> 
> The risk is that something which includes ftrace.h is depending upon
> the enum declaration.

You mean forward struct declaration. And if so, good! it needs to be fixed ;-)

-- Steve



More information about the Linux-security-module-archive mailing list