[PATCH v2] KEYS: trusted: add missing MODULE_DESCRIPTION()
Jarkko Sakkinen
jarkko at kernel.org
Tue Jun 4 16:43:05 UTC 2024
On Thu May 30, 2024 at 5:43 PM EEST, Jeff Johnson wrote:
> kbuild reports:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in security/keys/trusted-keys/trusted.o
>
> Add the missing MODULE_DESCRIPTION() macro invocation.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson at quicinc.com>
> ---
> Changes in v2:
> - reword commit text per Jarkko's guidance
> - Link to v1: https://lore.kernel.org/r/20240529-md-trusted-v1-1-56c9a0ae8e28@quicinc.com
> ---
> security/keys/trusted-keys/trusted_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/security/keys/trusted-keys/trusted_core.c b/security/keys/trusted-keys/trusted_core.c
> index 5113aeae5628..f4ab16d59663 100644
> --- a/security/keys/trusted-keys/trusted_core.c
> +++ b/security/keys/trusted-keys/trusted_core.c
> @@ -395,4 +395,5 @@ static void __exit cleanup_trusted(void)
> late_initcall(init_trusted);
> module_exit(cleanup_trusted);
>
> +MODULE_DESCRIPTION("Trusted Key support");
First this should be just "Trusted key type".
Second: neither encrypted keys has the description.
So I'd consider also "Encrypted key type" for that one.
So this really needs two patches to be done properly.
BR, Jarkko
More information about the Linux-security-module-archive
mailing list