[PATCH 2/6] tracing: Replace memcpy() with __get_task_comm()

Linus Torvalds torvalds at linux-foundation.org
Mon Jun 3 21:42:10 UTC 2024


On Mon, 3 Jun 2024 at 14:19, Steven Rostedt <rostedt at goodmis.org> wrote:
>
> -               __array(        char,   comm,   TASK_COMM_LEN   )
> +               __string(       comm,   strlen(comm)            )

Is this actually safe is 'comm[]' is being modified at the same time?
The 'strlen()' will not be consistent with the string copy.

Because that is very much the case. It's not a stable source.

For example, strlen() may return 5. But by the time  you then actually
copy the data, the string may have changed, and there would not
necessarily be a NUL character at comm[5] any more. It might be
further in the string, or it might be earlier.

                  Linus



More information about the Linux-security-module-archive mailing list