[PATCH v5 16/21] mm/mmap: Use vms accounted pages in mmap_region()

Liam R. Howlett Liam.Howlett at oracle.com
Wed Jul 17 20:07:04 UTC 2024


From: "Liam R. Howlett" <Liam.Howlett at Oracle.com>

Change from nr_pages variable to vms.nr_accounted for the charged pages
calculation.  This is necessary for a future patch.

This also avoids checking security_vm_enough_memory_mm() if the amount
of memory won't change.

Signed-off-by: Liam R. Howlett <Liam.Howlett at Oracle.com>
Cc: Kees Cook <kees at kernel.org>
Cc: linux-security-module at vger.kernel.org
Reviewed-by: Kees Cook <kees at kernel.org>
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes at oracle.com>
Reviewed-by: Suren Baghdasaryan <surenb at google.com>
---
 mm/mmap.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mm/mmap.c b/mm/mmap.c
index 45fb8725a6c5..9f870e715a47 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -3026,9 +3026,10 @@ unsigned long mmap_region(struct file *file, unsigned long addr,
 	 */
 	if (accountable_mapping(file, vm_flags)) {
 		charged = pglen;
-		charged -= nr_accounted;
-		if (security_vm_enough_memory_mm(mm, charged))
+		charged -= vms.nr_accounted;
+		if (charged && security_vm_enough_memory_mm(mm, charged))
 			goto abort_munmap;
+
 		vms.nr_accounted = 0;
 		vm_flags |= VM_ACCOUNT;
 	}
-- 
2.43.0




More information about the Linux-security-module-archive mailing list