[PATCH] KEYS: encrypted: Add check for strsep

Jarkko Sakkinen jarkko at kernel.org
Tue Jan 30 17:22:27 UTC 2024


On Wed Jan 24, 2024 at 11:10 PM EET, Verma, Vishal L wrote:
> On Wed, 2024-01-24 at 15:40 -0500, Mimi Zohar wrote:
> > On Wed, 2024-01-24 at 20:10 +0000, Verma, Vishal L wrote:
> > > > 
> > > Ah, thanks for confirming! Would you like me to send a revert patch or
> > > will you do it?
> > 
> > Revert "KEYS: encrypted: Add check for strsep"
> >     
> > This reverts commit b4af096b5df5dd131ab796c79cedc7069d8f4882.
> >     
> > New encrypted keys are created either from kernel-generated random
> > numbers or user-provided decrypted data.  Revert the change requiring
> > user-provided decrypted data.
> > 
> > 
> > Can I add your Reported-by?
>
> Yes that works, Thank you.

This went totally wrong IMHO.

Priority should be to locate and fix the bug not revert useful stuff
when a bug is found that has limited scope.

BR, Jarkko



More information about the Linux-security-module-archive mailing list