回复: [PATCH v4] selftests/landlock:Fix two build issues

Huyadi hu.yadi at h3c.com
Tue Jan 23 12:04:17 UTC 2024


>> Changes v3 -> v2:
>>  - add helper of gettid instead of __NR_gettid
>>  - add gcc/glibc version info in comments Changes v1 -> v2:
>>  - fix whitespace error
>>  - replace SYS_gettid with _NR_gettid
>> 
>>  tools/testing/selftests/landlock/fs_test.c  | 5 ++++-  
>> tools/testing/selftests/landlock/net_test.c | 7 ++++++-
>>  2 files changed, 10 insertions(+), 2 deletions(-)
>> 
>> diff --git a/tools/testing/selftests/landlock/fs_test.c 
>> b/tools/testing/selftests/landlock/fs_test.c
>> index 18e1f86a6234..a992cf7c0ad1 100644
>> --- a/tools/testing/selftests/landlock/fs_test.c
>> +++ b/tools/testing/selftests/landlock/fs_test.c
>> @@ -4572,7 +4572,10 @@ FIXTURE_VARIANT(layout3_fs)
>>  /* clang-format off */
>>  FIXTURE_VARIANT_ADD(layout3_fs, tmpfs) {
>>  	/* clang-format on */
>> -	.mnt = mnt_tmp,
>> +	.mnt = {
>> +		.type = "tmpfs",
>> +		.data = "size=4m,mode=700",
>> +	},
>
>I requested some changes here.
>

Could you give me some inspiration how to fix it? 
it looks fine to me to assign value as above, which consistent with other pseudo FS tests.
Thanks in advance.

>>  	.file_path = file1_s1d1,
>>  };
>> 
  


More information about the Linux-security-module-archive mailing list