[PATCH] security: smack: Fix indentation in smack_netfilter.c

Casey Schaufler casey at schaufler-ca.com
Thu Aug 22 20:42:50 UTC 2024


On 8/22/2024 8:34 AM, Casey Schaufler wrote:
> On 8/22/2024 2:18 AM, GiSeong Ji wrote:
>> Aligned parameters in the function declaration of smack_ip_output
>> to adhere to the Linux kernel coding style guidelines.
>>
>> The parameters of the smack_ip_output function were previously misaligned,
>> with the second and third parameters not aligned under the first parameter.
>> This change corrects the indentation, improving code readability and
>> maintaining consistency with the rest of the codebase.
>>
>> Signed-off-by: GiSeong Ji <jiggyjiggy0323 at gmail.com>
> Thanks. I'll take this in the Smack tree.

Your patch was whitespace damaged. The tabs in your change were
replaced by spaces. I fixed that, and have applied the change to
smack-next. 

>
>> ---
>>  security/smack/smack_netfilter.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/security/smack/smack_netfilter.c b/security/smack/smack_netfilter.c
>> index b945c1d3a743..ce06cd268d81 100644
>> --- a/security/smack/smack_netfilter.c
>> +++ b/security/smack/smack_netfilter.c
>> @@ -19,8 +19,8 @@
>>  #include "smack.h"
>>  
>>  static unsigned int smack_ip_output(void *priv,
>> -					struct sk_buff *skb,
>> -					const struct nf_hook_state *state)
>> +                                    struct sk_buff *skb,
>> +                                    const struct nf_hook_state *state)
>>  {
>>  	struct sock *sk = skb_to_full_sk(skb);
>>  	struct socket_smack *ssp;



More information about the Linux-security-module-archive mailing list