[PATCH bpf-next v2 2/7] bpf, lsm: Add return value range description for lsm hook

KP Singh kpsingh at kernel.org
Mon Apr 8 17:09:25 UTC 2024



> On 25 Mar 2024, at 10:56, Xu Kuohai <xukuohai at huaweicloud.com> wrote:
> 
> From: Xu Kuohai <xukuohai at huawei.com>
> 
> Add return value descriptions for lsm hook.
> 
> Two integer ranges are added:
> 
> 1. ERRNO: Integer between -MAX_ERRNO and 0, including -MAX_ERRNO and 0.
> 2. ANY: Any integer


I think you should merge this patch and the first patch. It's not clear that the first value in this macro is actually used as the default value until one reads the code. I think you also need to make it clear that there is no logical change on the LSM side in the this patch.

- KP


More information about the Linux-security-module-archive mailing list