[PATCH v4 bpf-next 07/12] bpf: consistenly use BPF token throughout BPF verifier logic
kernel test robot
lkp at intel.com
Wed Sep 13 22:15:14 UTC 2023
Hi Andrii,
kernel test robot noticed the following build errors:
[auto build test ERROR on bpf-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Andrii-Nakryiko/bpf-add-BPF-token-delegation-mount-options-to-BPF-FS/20230913-053240
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link: https://lore.kernel.org/r/20230912212906.3975866-8-andrii%40kernel.org
patch subject: [PATCH v4 bpf-next 07/12] bpf: consistenly use BPF token throughout BPF verifier logic
config: x86_64-randconfig-074-20230914 (https://download.01.org/0day-ci/archive/20230914/202309140537.jHmBqMd6-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230914/202309140537.jHmBqMd6-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309140537.jHmBqMd6-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/net/sock_reuseport.h:5,
from include/net/tcp.h:35,
from include/linux/netfilter_ipv6.h:11,
from include/uapi/linux/netfilter_ipv6/ip6_tables.h:22,
from include/linux/netfilter_ipv6/ip6_tables.h:23,
from net/ipv6/netfilter/ip6table_filter.c:11:
include/linux/filter.h: In function 'bpf_jit_blinding_enabled':
>> include/linux/filter.h:1104:36: error: implicit declaration of function 'bpf_token_capable'; did you mean 'bpf_token_put'? [-Werror=implicit-function-declaration]
1104 | if (bpf_jit_harden == 1 && bpf_token_capable(prog->aux->token, CAP_BPF))
| ^~~~~~~~~~~~~~~~~
| bpf_token_put
cc1: some warnings being treated as errors
--
In file included from include/net/sock_reuseport.h:5,
from include/net/tcp.h:35,
from include/linux/netfilter_ipv6.h:11,
from net/ipv6/netfilter/nf_reject_ipv6.c:12:
include/linux/filter.h: In function 'bpf_jit_blinding_enabled':
>> include/linux/filter.h:1104:36: error: implicit declaration of function 'bpf_token_capable'; did you mean 'bpf_token_put'? [-Werror=implicit-function-declaration]
1104 | if (bpf_jit_harden == 1 && bpf_token_capable(prog->aux->token, CAP_BPF))
| ^~~~~~~~~~~~~~~~~
| bpf_token_put
net/ipv6/netfilter/nf_reject_ipv6.c: In function 'nf_send_reset6':
net/ipv6/netfilter/nf_reject_ipv6.c:287:25: warning: variable 'ip6h' set but not used [-Wunused-but-set-variable]
287 | struct ipv6hdr *ip6h;
| ^~~~
cc1: some warnings being treated as errors
vim +1104 include/linux/filter.h
1091
1092 static inline bool bpf_jit_blinding_enabled(struct bpf_prog *prog)
1093 {
1094 /* These are the prerequisites, should someone ever have the
1095 * idea to call blinding outside of them, we make sure to
1096 * bail out.
1097 */
1098 if (!bpf_jit_is_ebpf())
1099 return false;
1100 if (!prog->jit_requested)
1101 return false;
1102 if (!bpf_jit_harden)
1103 return false;
> 1104 if (bpf_jit_harden == 1 && bpf_token_capable(prog->aux->token, CAP_BPF))
1105 return false;
1106
1107 return true;
1108 }
1109
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the Linux-security-module-archive
mailing list