[RFC PATCH v2 2/6] mm: mempolicy: Revise comment regarding mempolicy mode flags

Yafang Shao laoar.shao at gmail.com
Thu Nov 23 12:21:33 UTC 2023


On Thu, Nov 23, 2023 at 2:32 PM Huang, Ying <ying.huang at intel.com> wrote:
>
> Yafang Shao <laoar.shao at gmail.com> writes:
>
> > MPOL_F_STATIC_NODES, MPOL_F_RELATIVE_NODES, and MPOL_F_NUMA_BALANCING are
> > mode flags applicable to both set_mempolicy(2) and mbind(2) system calls.
> > It's worth noting that MPOL_F_NUMA_BALANCING was initially introduced in
> > commit bda420b98505 ("numa balancing: migrate on fault among multiple bound
> > nodes") exclusively for set_mempolicy(2). However, it was later made a
> > shared flag for both set_mempolicy(2) and mbind(2) following
> > commit 6d2aec9e123b ("mm/mempolicy: do not allow illegal
> > MPOL_F_NUMA_BALANCING | MPOL_LOCAL in mbind()").
> >
> > This revised version aims to clarify the details regarding the mode flags.
> >
> > Signed-off-by: Yafang Shao <laoar.shao at gmail.com>
> > Cc: Eric Dumazet <edumazet at google.com>
> > Cc: "Huang, Ying" <ying.huang at intel.com>
>
> Thanks for fixing this.
>
> Reviewed-by: "Huang, Ying" <ying.huang at intel.com>
>
> And, please revise the manpage for mbind() too.  As we have done for
> set_mempolicy(),
>
> https://lore.kernel.org/all/20210120061235.148637-3-ying.huang@intel.com/

Thanks for your review. will do it.

-- 
Regards
Yafang



More information about the Linux-security-module-archive mailing list