[PATCH v3 06/57] sched: Simplify sysctl_sched_uclamp_handler()
Dan Carpenter
dan.carpenter at linaro.org
Mon Jun 12 13:47:04 UTC 2023
On Mon, Jun 12, 2023 at 11:07:19AM +0200, Peter Zijlstra wrote:
> @@ -1810,7 +1811,7 @@ static int sysctl_sched_uclamp_handler(s
> if (result)
> goto undo;
> if (!write)
> - goto done;
> + return result;
This would be nicer as a "return 0;"
>
> if (sysctl_sched_uclamp_util_min > sysctl_sched_uclamp_util_max ||
> sysctl_sched_uclamp_util_max > SCHED_CAPACITY_SCALE ||
> @@ -1846,16 +1847,12 @@ static int sysctl_sched_uclamp_handler(s
> * Otherwise, keep it simple and do just a lazy update at each next
> * task enqueue time.
> */
> -
> - goto done;
> + return result;
This is a return 0 as well.
regards,
dan carpenter
>
> undo:
> sysctl_sched_uclamp_util_min = old_min;
> sysctl_sched_uclamp_util_max = old_max;
> sysctl_sched_uclamp_util_min_rt_default = old_min_rt;
> -done:
> - mutex_unlock(&uclamp_mutex);
> -
> return result;
> }
More information about the Linux-security-module-archive
mailing list