[RFC bpf-next v7 4/6] selftests/bpf: use random netns name for mptcp
Geliang Tang
geliang.tang at suse.com
Sat Jul 29 09:57:25 UTC 2023
Use rand() to generate a random netns name instead of using the fixed
name "mptcp_ns" for every test.
By doing that, we can re-launch the test even if there was an issue
removing the previous netns or if by accident, a netns with this generic
name already existed on the system.
Note that using a different name each will also help adding more
subtests in future commits.
Signed-off-by: Geliang Tang <geliang.tang at suse.com>
Reviewed-by: Matthieu Baerts <matthieu.baerts at tessares.net>
---
tools/testing/selftests/bpf/prog_tests/mptcp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/prog_tests/mptcp.c b/tools/testing/selftests/bpf/prog_tests/mptcp.c
index cd0c42fff7c0..4ccca3d39a8f 100644
--- a/tools/testing/selftests/bpf/prog_tests/mptcp.c
+++ b/tools/testing/selftests/bpf/prog_tests/mptcp.c
@@ -7,7 +7,7 @@
#include "network_helpers.h"
#include "mptcp_sock.skel.h"
-#define NS_TEST "mptcp_ns"
+char NS_TEST[32];
#ifndef TCP_CA_NAME_MAX
#define TCP_CA_NAME_MAX 16
@@ -147,6 +147,8 @@ static void test_base(void)
if (!ASSERT_GE(cgroup_fd, 0, "test__join_cgroup"))
return;
+ srand(time(NULL));
+ snprintf(NS_TEST, sizeof(NS_TEST), "mptcp_ns_%d", rand());
SYS(fail, "ip netns add %s", NS_TEST);
SYS(fail, "ip -net %s link set dev lo up", NS_TEST);
--
2.35.3
More information about the Linux-security-module-archive
mailing list