[PATCH -next] evm: Support small xattr in dump_security_xattr()

Mimi Zohar zohar at linux.ibm.com
Wed Jan 18 20:23:43 UTC 2023


Hi Xiu,

Thank you for cleaning up the code.  The purpose of this patch is to
remove code duplication.   Perhaps rename the patch to "evm: call
dump_security_xattr() in all cases to remove code duplication".

On Mon, 2022-12-26 at 18:24 +0800, Xiu Jianfeng wrote:
> Currently the debug function of dumping xattr is splited into two parts,
> when the length of xattr is less than 64 bytes, it uses pr_debug()
> directly. Merge it into dump_security_xattr() to simplify the code, no
> functional changes here.
> 
> Signed-off-by: Xiu Jianfeng <xiujianfeng at huawei.com>

Please reword the patch description in terms of removing code
duplication.

-- 
thanks,

Mimi



More information about the Linux-security-module-archive mailing list