[PATCH] ima: fix ima_delete_rules() kernel-doc warning

Paul Moore paul at paul-moore.com
Fri Jan 6 21:21:25 UTC 2023


On Mon, Jan 2, 2023 at 3:45 PM Randy Dunlap <rdunlap at infradead.org> wrote:
>
> Use correct kernel-doc syntax in the function description to
> prevent a kernel-doc warning:
>
> security/integrity/ima/ima_policy.c:1964: warning: expecting prototype for ima_delete_rules() called to cleanup invalid in(). Prototype was for ima_delete_rules() instead
>
> Signed-off-by: Randy Dunlap <rdunlap at infradead.org>
> Cc: Mimi Zohar <zohar at linux.ibm.com>
> Cc: Dmitry Kasatkin <dmitry.kasatkin at gmail.com>
> Cc: linux-integrity at vger.kernel.org
> Cc: Paul Moore <paul at paul-moore.com>
> Cc: James Morris <jmorris at namei.org>
> Cc: "Serge E. Hallyn" <serge at hallyn.com>
> ---
>  security/integrity/ima/ima_policy.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Paul Moore <paul at paul-moore.com>

> diff -- a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c
> --- a/security/integrity/ima/ima_policy.c
> +++ b/security/integrity/ima/ima_policy.c
> @@ -1955,7 +1955,8 @@ ssize_t ima_parse_add_rule(char *rule)
>  }
>
>  /**
> - * ima_delete_rules() called to cleanup invalid in-flight policy.
> + * ima_delete_rules() - called to cleanup invalid in-flight policy.
> + *
>   * We don't need locking as we operate on the temp list, which is
>   * different from the active one.  There is also only one user of
>   * ima_delete_rules() at a time.

-- 
paul-moore.com



More information about the Linux-security-module-archive mailing list