[PATCH v5 4/4] vduse: Add LSM hook to check Virtio device type

Stephen Smalley stephen.smalley.work at gmail.com
Mon Dec 18 17:21:18 UTC 2023


On Tue, Dec 12, 2023 at 8:17 AM Maxime Coquelin
<maxime.coquelin at redhat.com> wrote:
>
> This patch introduces a LSM hook for devices creation,
> destruction (ioctl()) and opening (open()) operations,
> checking the application is allowed to perform these
> operations for the Virtio device type.

Can you explain why the existing LSM hooks and SELinux implementation
are not sufficient? We already control the ability to open device
nodes via selinux_inode_permission() and selinux_file_open(), and can
support fine-grained per-cmd ioctl checking via selinux_file_ioctl().
And it should already be possible to label these nodes distinctly
through existing mechanisms (file_contexts if udev-created/labeled,
genfs_contexts if kernel-created). What exactly can't you do today
that this hook enables?



More information about the Linux-security-module-archive mailing list