[PATCH v8 5/5] security: Add CONFIG_SECURITY_HOOK_LIKELY

[Paul Moore]

On Fri, Dec 8, 2023 at 12:46 PM Paul Moore <paul at paul-moore.com> wrote:
> On Fri, Dec 8, 2023 at 12:36 PM Kees Cook <keescook at chromium.org> wrote:
> > On Fri, Nov 10, 2023 at 11:20:37PM +0100, KP Singh wrote:
> > > [...]
> > > ---
> > >  security/Kconfig | 11 +++++++++++
> > >  1 file changed, 11 insertions(+)
> >
> > Did something go missing from this patch? I don't see anything depending
> > on CONFIG_SECURITY_HOOK_LIKELY (I think this was working in v7, though?)

I guess while I'm at it, and for the sake of the mailing list, it is
worth mentioning that I voiced my dislike of the
CONFIG_SECURITY_HOOK_LIKELY Kconfig option earlier this year yet it
continues to appear in the patchset.  It's hard to give something
priority when I do provide some feedback and it is apparently ignored.

> > Regardless, Paul, please take patches 1-4, they bring us measurable
> > speed-ups across the board.
>
> As I mentioned when you were poking me off-list, this is in my review
> queue and I will get to it when it reaches the top.  I can promise you
> that continued nudging doesn't move the patchset further up in the
> queue, it actually has the opposite effect.

-- 
paul-moore.com