[PATCH 05/11] selinux: use dlist for isec inode list
Paul Moore
paul at paul-moore.com
Wed Dec 6 21:52:42 UTC 2023
On Wed, Dec 6, 2023 at 1:07 AM Dave Chinner <david at fromorbit.com> wrote:
>
> From: Dave Chinner <dchinner at redhat.com>
>
> Because it's a horrible point of lock contention under heavily
> concurrent directory traversals...
>
> - 12.14% d_instantiate
> - 12.06% security_d_instantiate
> - 12.13% selinux_d_instantiate
> - 12.16% inode_doinit_with_dentry
> - 15.45% _raw_spin_lock
> - do_raw_spin_lock
> 14.68% __pv_queued_spin_lock_slowpath
>
>
> Signed-off-by: Dave Chinner <dchinner at redhat.com>
> ---
> include/linux/dlock-list.h | 9 ++++
> security/selinux/hooks.c | 72 +++++++++++++++----------------
> security/selinux/include/objsec.h | 6 +--
> 3 files changed, 47 insertions(+), 40 deletions(-)
In the cover letter you talk about testing, but I didn't see any
mention of testing with SELinux enabled. Given the lock contention
stats in the description above I'm going to assume you did test this
and pass along my ACK, but if you haven't tested the changes below
please do before sending this anywhere important.
Acked-by: Paul Moore <paul at paul-moore.com>
--
paul-moore.com
More information about the Linux-security-module-archive
mailing list