[PATCH] selftests/landlock: Fix a resource leak
Ding Xiang
dingxiang at cmss.chinamobile.com
Wed Aug 30 06:08:58 UTC 2023
The opened file should be closed before return,
otherwise resource leak will occur
Signed-off-by: Ding Xiang <dingxiang at cmss.chinamobile.com>
---
tools/testing/selftests/landlock/fs_test.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/landlock/fs_test.c b/tools/testing/selftests/landlock/fs_test.c
index 83d565569512..687a66ea9799 100644
--- a/tools/testing/selftests/landlock/fs_test.c
+++ b/tools/testing/selftests/landlock/fs_test.c
@@ -124,13 +124,17 @@ static bool supports_filesystem(const char *const filesystem)
return true;
/* filesystem can be null for bind mounts. */
- if (!filesystem)
+ if (!filesystem) {
+ fclose(inf);
return true;
+ }
len = snprintf(str, sizeof(str), "nodev\t%s\n", filesystem);
- if (len >= sizeof(str))
+ if (len >= sizeof(str)) {
+ fclose(inf);
/* Ignores too-long filesystem names. */
return true;
+ }
res = fgrep(inf, str);
fclose(inf);
--
2.38.1
More information about the Linux-security-module-archive
mailing list