> +extern int __orangefs_set_acl(struct inode *inode, struct posix_acl *acl, > + int type); No real need for the extern here (or any other function prototype in headers). Otherwise looks good: Reviewed-by: Christoph Hellwig <hch at lst.de>