[PATCH 5/5] smack: Remove redundant assignments

Casey Schaufler casey at schaufler-ca.com
Thu Mar 31 18:44:19 UTC 2022


On 3/31/2022 10:33 AM, Michal Orzel wrote:
> Get rid of redundant assignments which end up in values not being
> read either because they are overwritten or the function ends.
>
> Reported by clang-tidy [deadcode.DeadStores]
>
> Signed-off-by: Michal Orzel <michalorzel.eng at gmail.com>

Thank you. I will take this via the Smack tree.

> ---
>   security/smack/smackfs.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
> index 658eab05599e..9e61014073cc 100644
> --- a/security/smack/smackfs.c
> +++ b/security/smack/smackfs.c
> @@ -1192,7 +1192,6 @@ static ssize_t smk_write_net4addr(struct file *file, const char __user *buf,
>   			rc = -EINVAL;
>   			goto free_out;
>   		}
> -		m = BEBITS;
>   		masks = 32;
>   	}
>   	if (masks > BEBITS) {



More information about the Linux-security-module-archive mailing list