[PATCH v5 bpf-next 0/5] Add bpf_getxattr

[KP Singh]

On Tue, Jun 28, 2022 at 7:13 PM Christian Brauner <brauner at kernel.org> wrote:
>
> On Tue, Jun 28, 2022 at 04:19:43PM +0000, KP Singh wrote:
> > v4 -> v5
> >
> > - Fixes suggested by Andrii
> >
> > v3 -> v4
> >
> > - Fixed issue incorrect increment of arg counter
> > - Removed __weak and noinline from kfunc definiton
> > - Some other minor fixes.
> >
> > v2 -> v3
> >
> > - Fixed missing prototype error
> > - Fixes suggested by other Joanne and Kumar.
> >
> > v1 -> v2
> >
> > - Used kfuncs as suggested by Alexei
> > - Used Benjamin Tissoires' patch from the HID v4 series to add a
> >   sleepable kfunc set (I sent the patch as a part of this series as it
> >   seems to have been dropped from v5) and acked it. Hope this is okay.
> > - Added support for verifying string constants to kfuncs
>
> Hm, I mean this isn't really giving any explanation as to why you are
> doing this. There's literally not a single sentence about the rationale?
> Did you accidently forget to put that into the cover letter? :)


Yes, actually I did forget to copy paste :)

Foundation for building more complex security policies using the
BPF LSM as presented in LSF/MM/BPF:

http://vger.kernel.org/bpfconf2022_material/lsfmmbpf2022-xattr.pdf\

See: https://lore.kernel.org/bpf/20220624045636.3668195-1-kpsingh@kernel.org/


>
> >
> >
> >
> > Benjamin Tissoires (1):
> >   btf: Add a new kfunc set which allows to mark a function to be
> >     sleepable
> >
> > KP Singh (4):
> >   bpf: kfunc support for ARG_PTR_TO_CONST_STR
> >   bpf: Allow kfuncs to be used in LSM programs
> >   bpf: Add a bpf_getxattr kfunc
> >   bpf/selftests: Add a selftest for bpf_getxattr
> >
> >  include/linux/bpf_verifier.h                  |  2 +
> >  include/linux/btf.h                           |  2 +
> >  kernel/bpf/btf.c                              | 43 ++++++++-
> >  kernel/bpf/verifier.c                         | 89 +++++++++++--------
> >  kernel/trace/bpf_trace.c                      | 42 +++++++++
> >  .../testing/selftests/bpf/prog_tests/xattr.c  | 54 +++++++++++
> >  tools/testing/selftests/bpf/progs/xattr.c     | 37 ++++++++
> >  7 files changed, 229 insertions(+), 40 deletions(-)
> >  create mode 100644 tools/testing/selftests/bpf/prog_tests/xattr.c
> >  create mode 100644 tools/testing/selftests/bpf/progs/xattr.c
> >
> > --
> > 2.37.0.rc0.161.g10f37bed90-goog
> >