[PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation
Steven Rostedt
rostedt at goodmis.org
Wed Jan 19 15:01:02 UTC 2022
On Wed, 19 Jan 2022 11:15:08 +0200
Andy Shevchenko <andy.shevchenko at gmail.com> wrote:
> > +static inline const char *yesno(bool v) { return v ? "yes" : "no"; }
>
>
>
> Perhaps keep it on 4 lines? Yes, yes/no is short, but if we add others
> (enable/disable) it will not be possible to keep on one line. And hence
> style will be broken among similar functions.
Agreed. Functions should always be of the normal format:
type func(params)
{
body;
}
Unless it is a stub function.
type func(params) { return 0; }
-- Steve
More information about the Linux-security-module-archive
mailing list