[PATCH] hardening: Default to INIT_STACK_ALL_ZERO if CC_HAS_AUTO_VAR_INIT_ZERO

Will Deacon will at kernel.org
Tue Sep 14 10:28:37 UTC 2021


CC_HAS_AUTO_VAR_INIT_ZERO requires a supported set of compiler options
distinct from those needed by CC_HAS_AUTO_VAR_INIT_PATTERN, Fix up
the Kconfig dependency for INIT_STACK_ALL_ZERO to test for the former
instead of the latter, as these are the options passed by the top-level
Makefile.

Cc: Kees Cook <keescook at chromium.org>
Cc: Nathan Chancellor <nathan at kernel.org>
Cc: Nick Desaulniers <ndesaulniers at google.com>
Cc: Gustavo A. R. Silva <gustavoars at kernel.org>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
Fixes: dcb7c0b9461c ("hardening: Clarify Kconfig text for auto-var-init")
Signed-off-by: Will Deacon <will at kernel.org>
---

I just noticed this while reading the code and I suspect it doesn't really
matter in practice.

 security/Kconfig.hardening | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/Kconfig.hardening b/security/Kconfig.hardening
index 90cbaff86e13..341e2fdcba94 100644
--- a/security/Kconfig.hardening
+++ b/security/Kconfig.hardening
@@ -29,7 +29,7 @@ choice
 	prompt "Initialize kernel stack variables at function entry"
 	default GCC_PLUGIN_STRUCTLEAK_BYREF_ALL if COMPILE_TEST && GCC_PLUGINS
 	default INIT_STACK_ALL_PATTERN if COMPILE_TEST && CC_HAS_AUTO_VAR_INIT_PATTERN
-	default INIT_STACK_ALL_ZERO if CC_HAS_AUTO_VAR_INIT_PATTERN
+	default INIT_STACK_ALL_ZERO if CC_HAS_AUTO_VAR_INIT_ZERO
 	default INIT_STACK_NONE
 	help
 	  This option enables initialization of stack variables at
-- 
2.33.0.309.g3052b89438-goog



More information about the Linux-security-module-archive mailing list