[PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys
sumit.garg at linaro.org
Wed Mar 17 07:39:53 UTC 2021
On Wed, 17 Mar 2021 at 04:45, Richard Weinberger
<richard.weinberger at gmail.com> wrote:
> On Tue, Mar 16, 2021 at 6:24 PM Ahmad Fatoum <a.fatoum at pengutronix.de> wrote:
> > +#include <keys/trusted_caam.h>
> > +#include <keys/trusted-type.h>
> > +#include <linux/build_bug.h>
> > +#include <linux/key-type.h>
> > +#include <soc/fsl/caam-blob.h>
> > +
> > +struct caam_blob_priv *blobifier;
> Who is using this pointer too?
> Otherwise I'd suggest marking it static.
> > module_param_named(source, trusted_key_source, charp, 0);
> > -MODULE_PARM_DESC(source, "Select trusted keys source (tpm or tee)");
> > +MODULE_PARM_DESC(source, "Select trusted keys source (tpm, tee or caam)");
> I didn't closely follow the previous discussions, but is a module
> parameter really the right approach?
> Is there also a way to set it via something like device tree?
It's there to support a platform which possesses multiple trusted keys
backends. So that a user is able to select during boot which one to
use as a backend.
More information about the Linux-security-module-archive