[PATCH] cipso, calipso: resolve a number of problems with the DOI refcounts

Paul Moore paul at paul-moore.com
Thu Mar 4 23:13:21 UTC 2021

On Thu, Mar 4, 2021 at 5:33 PM David Miller <davem at davemloft.net> wrote:
> From: Paul Moore <paul at paul-moore.com>
> Date: Thu, 04 Mar 2021 16:29:51 -0500
> > +static void calipso_doi_putdef(struct calipso_doi *doi_def);
> > +
> This is a global symbol, so why the static decl here?

To resolve this:

  CC      net/ipv6/calipso.o
net/ipv6/calipso.c: In function ‘calipso_doi_remove’:
net/ipv6/calipso.c:453:2: error: implicit declaration of function ‘calipso_doi_p

I think there are some odd things with how the CALIPSO prototypes are
handled, some of that I'm guessing is due to handling IPv6
as-a-module, but regardless of the reason it seemed like the smallest
fix was to add the forward declaration at the top of the file.
Considering that I believe this should be sent to -stable I figured a
smaller patch, with less chance for merge conflicts, would be more

Or are you simply concerned about the static tag?  I simply kept the
static from the function definition; removing it causes a mismatch
which makes the compiler unhappy.

Either way, if you want this done another way, let me know what you
want and I'll respin it.

paul moore

More information about the Linux-security-module-archive mailing list