[PATCH v2 01/10] vfs: move cap_convert_nscap() call into vfs_setxattr()

Miklos Szeredi miklos at szeredi.hu
Tue Jan 12 10:04:46 UTC 2021

On Tue, Jan 12, 2021 at 10:43 AM Miklos Szeredi <miklos at szeredi.hu> wrote:

> The following semantics would make a ton more sense, since getting a
> v2 would indicate that rootid is unknown:
> - if cap is v2 convert to v3 with zero rootid
> - after this, check if rootid needs to be translated, if not return v3
> - if yes, try to translate to current ns, if succeeds return translated v3
> - if not mappable, return v2
> Hmm?

Actually, it would make even more sense to simply skip unconvertible
caps and return -ENODATA.  In fact that's what I thought would happen
until I looked at the -EOPNOTSUPP fallback code in vfs_getxattr().

Serge, do you remember what was the reason for the unconverted fallback?


More information about the Linux-security-module-archive mailing list