[PATCH] samples/landlock: fix path_list memory leak
mic at digikod.net
Wed Apr 28 09:58:59 UTC 2021
On 27/04/2021 21:13, Nick Desaulniers wrote:
> On Tue, Apr 27, 2021 at 11:38 AM <trix at redhat.com> wrote:
>> From: Tom Rix <trix at redhat.com>
>> Clang static analysis reports this error
>> sandboxer.c:134:8: warning: Potential leak of memory
>> pointed to by 'path_list'
>> ret = 0;
>> path_list is allocated in parse_path() but never freed.
>> Signed-off-by: Tom Rix <trix at redhat.com>
>> samples/landlock/sandboxer.c | 2 ++
>> 1 file changed, 2 insertions(+)
>> diff --git a/samples/landlock/sandboxer.c b/samples/landlock/sandboxer.c
>> index 7a15910d2171..4629d011ed61 100644
>> --- a/samples/landlock/sandboxer.c
>> +++ b/samples/landlock/sandboxer.c
>> @@ -134,6 +134,8 @@ static int populate_ruleset(
>> ret = 0;
>> + if (path_list)
>> + free(path_list);
> I don't think the conditional is even necessary? By our first `goto
> out_free_name;`, `parse_path` has already been called/memory for
> `path_list` has already been allocated. `parse_path` doesn't check
> whether `malloc` has failed.
Indeed, no need for the path_list check. In practice, this memory leak
doesn't stay long because of the execve, but I missed this free anyway.
Reviewed-by: Mickaël Salaün <mic at linux.microsoft.com>
>> return ret;
More information about the Linux-security-module-archive