[PATCH] ima: require CONFIG_MODULES for IMA_APPRAISE_MODSIG

Nayna nayna at linux.vnet.ibm.com
Thu Apr 22 17:23:31 UTC 2021


On 4/22/21 9:29 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd at arndb.de>
>
> When module support is disabled, CONFIG_MODULE_SIG_HASH cannot
> be set either, so the build process fails with an error
>
> certs/Makefile:52: *** Could not determine digest type to use from kernel config.  Stop.
>
> when IMA_APPRAISE_MODSIG is set but modules are not.
>
> Add a Kconfig dependency to prevent this configuration.
>
> Fixes: 0165f4ca223b ("ima: enable signing of modules with build time generated key")
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>

Thanks Arnd !!

This fix solves the config issue, but adds an unnecessary MODULES 
dependency on APPRAISE_MODSIG. APPRAISE_MODSIG can be used for kernel 
image(appended signature) as well as for kernel modules.

I am working on the fix. I am sorry for the delay, I got stuck with some 
urgent issues early this week.

Thanks & Regards,

       - Nayna



More information about the Linux-security-module-archive mailing list