[PATCH v3 00/38] idmapped mounts
Serge E. Hallyn
serge at hallyn.com
Sat Nov 28 22:54:50 UTC 2020
On Sat, Nov 28, 2020 at 10:34:49PM +0100, Christian Brauner wrote:
> Hey everyone,
Hey Christian,
a general request. Argue with me if it seems misguided.
When looking at a patch or a small hunk of code, these days, if a variable
called 'ns' or 'user_ns' is seen passed to a function, it can be easy to
assume which user_ns it is based on what you think would make sense, but if
your assumption is wrong, your patch review will be wrong.
Can we stick to a convention where we have maybe
subj_userns - the userns of the task seeking some action
obj_userns - the userns of the thing being acted on - task, superblock,...
mnt_userns - the userns of a mountpoint through which an object is seen
You're replacing a lot of such callers and callsites in this patchset, so
this would be a great time to start doing that.
-serge
More information about the Linux-security-module-archive
mailing list