[PATCH v23 20/23] Audit: Add new record for multiple process LSM attributes

kernel test robot lkp at intel.com
Fri Nov 20 22:51:20 UTC 2020


Hi Casey,

I love your patch! Yet something to improve:

[auto build test ERROR on nf/master]
[also build test ERROR on linus/master v5.10-rc4 next-20201120]
[cannot apply to nf-next/master security/next-testing]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Casey-Schaufler/LSM-Module-stacking-for-AppArmor/20201121-044616
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git master
config: sparc64-randconfig-s032-20201120 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-134-gb59dbdaf-dirty
        # https://github.com/0day-ci/linux/commit/5214e557315977360cc15d57d0622591dc5805c5
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Casey-Schaufler/LSM-Module-stacking-for-AppArmor/20201121-044616
        git checkout 5214e557315977360cc15d57d0622591dc5805c5
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=sparc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>

All errors (new ones prefixed by >>):

   In file included from arch/sparc/kernel/ptrace_64.c:25:
   include/linux/audit.h:585:1: error: expected identifier or '(' before '+' token
     585 | +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
         | ^
>> include/linux/audit.h:261:13: error: 'audit_log_lsm' defined but not used [-Werror=unused-function]
     261 | static void audit_log_lsm(struct audit_context *context)
         |             ^~~~~~~~~~~~~
   cc1: all warnings being treated as errors

vim +/audit_log_lsm +261 include/linux/audit.h

   216	
   217	#else /* CONFIG_AUDIT */
   218	static inline __printf(4, 5)
   219	void audit_log(struct audit_context *ctx, gfp_t gfp_mask, int type,
   220		       const char *fmt, ...)
   221	{ }
   222	static inline struct audit_buffer *audit_log_start(struct audit_context *ctx,
   223							   gfp_t gfp_mask, int type)
   224	{
   225		return NULL;
   226	}
   227	static inline __printf(2, 3)
   228	void audit_log_format(struct audit_buffer *ab, const char *fmt, ...)
   229	{ }
   230	static inline void audit_log_end(struct audit_buffer *ab)
   231	{ }
   232	static inline void audit_log_end_local(struct audit_buffer *ab,
   233					       struct audit_context *context)
   234	{ }
   235	static inline void audit_log_n_hex(struct audit_buffer *ab,
   236					   const unsigned char *buf, size_t len)
   237	{ }
   238	static inline void audit_log_n_string(struct audit_buffer *ab,
   239					      const char *buf, size_t n)
   240	{ }
   241	static inline void  audit_log_n_untrustedstring(struct audit_buffer *ab,
   242							const char *string, size_t n)
   243	{ }
   244	static inline void audit_log_untrustedstring(struct audit_buffer *ab,
   245						     const char *string)
   246	{ }
   247	static inline void audit_log_d_path(struct audit_buffer *ab,
   248					    const char *prefix,
   249					    const struct path *path)
   250	{ }
   251	static inline void audit_log_key(struct audit_buffer *ab, char *key)
   252	{ }
   253	static inline void audit_log_path_denied(int type, const char *operation)
   254	{ }
   255	static inline int audit_log_task_context(struct audit_buffer *ab)
   256	{
   257		return 0;
   258	}
   259	static inline void audit_log_task_info(struct audit_buffer *ab)
   260	{ }
 > 261	static void audit_log_lsm(struct audit_context *context)
   262	{ }
   263	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org


More information about the Linux-security-module-archive mailing list