[PATCH v5 2/2] KEYS: Avoid false positive ENOMEM error on key read

Jarkko Sakkinen jarkko.sakkinen at linux.intel.com
Thu Mar 19 19:46:50 UTC 2020


On Wed, Mar 18, 2020 at 06:14:57PM -0400, Waiman Long wrote:
> +			 * It is possible, though unlikely, that the key
> +			 * changes in between the up_read->down_read period.
> +			 * If the key becomes longer, we will have to
> +			 * allocate a larger buffer and redo the key read
> +			 * again.
> +			 */
> +			if (!tmpbuf || unlikely(ret > tmpbuflen)) {

Shouldn't you check that tmpbuflen stays below buflen (why else
you had made copy of buflen otherwise)?

/Jarkko



More information about the Linux-security-module-archive mailing list