[PATCH v4 4/4] KEYS: Avoid false positive ENOMEM error on key read

David Howells dhowells at redhat.com
Wed Mar 18 08:27:34 UTC 2020


Waiman Long <longman at redhat.com> wrote:

> +static inline void __kvzfree(const void *addr, size_t len)
> +{
> +	if (addr) {
> +		memset((void *)addr, 0, len);
> +		kvfree(addr);
> +	}
> +}

I wonder if that would be better as "kvfree(memset(...))" as memset() will
return the address parameter.  If memset is not inline, it avoids the need for
the compiler to save the parameter.

David



More information about the Linux-security-module-archive mailing list