[PATCH v3 3/3] KEYS: Use kvmalloc() to better handle large buffer allocation

Jarkko Sakkinen jarkko.sakkinen at linux.intel.com
Sun Mar 15 21:52:53 UTC 2020


On Fri, Mar 13, 2020 at 01:49:57PM -0400, Waiman Long wrote:
> >>  			if (!tmpbuf || unlikely(ret > tmpbuflen)) {
> >>  				if (unlikely(tmpbuf))
> >> -					kzfree(tmpbuf);
> >> +					__kvzfree(tmpbuf, tmpbuflen);
> > Both kzfree() and __kvzfree() handle a NULL pointer, so there's no need for the
> > NULL check first.
> >
> I would like to keep this one because of the unlikely annotation.

What (measurable) gain does it bring anyway?

/Jarkko



More information about the Linux-security-module-archive mailing list