[PATCH v2 2/2] KEYS: Avoid false positive ENOMEM error on key read

Waiman Long longman at redhat.com
Tue Mar 10 15:45:56 UTC 2020

On 3/9/20 12:32 PM, David Howells wrote:
> Waiman Long <longman at redhat.com> wrote:
>> +			tmpbuf = kmalloc(tbuflen, GFP_KERNEL);
> This would probably be better off using kvmalloc() - otherwise big objects
> have to be constructed from runs of contiguous pages.  But since all we're
> doing is buffering for userspace, we don't care about that.
> If you agree, we can address it with an additional patch.
> David

That is certainly fine with me. I don't care if the pages are contiguous
or not. Will add a patch 3 for that as suggested.


More information about the Linux-security-module-archive mailing list