[PATCH 10/13] integrity/ima: switch to using __kernel_read

Linus Torvalds torvalds at linux-foundation.org
Mon Jun 15 16:56:59 UTC 2020


On Mon, Jun 15, 2020 at 9:46 AM Linus Torvalds
<torvalds at linux-foundation.org> wrote:
>
> It worries me that you're making these kinds of transformations where
> the comments imply it's a no-op, but the actual code doesn't agree.

Note that it's not that I think the FMODE_READ check is necessarily
_needed_. It's more the discrepancy between the commit message and the
code change that I don't like.

The commit message implies that __kernel_read() has _more_ checks than
the checks done by integrity_kernel_read(). But it looks like they
aren't so much "more" as they are just "different".

                Linus



More information about the Linux-security-module-archive mailing list