trix at redhat.com wrote: > - if (copy_from_user(&uparams, _params, sizeof(uparams)) != 0) > - return -EFAULT; > - > ret = keyctl_pkey_params_get(uparams.key_id, _info, params); Erm... uparams is used on the very next statement after the copy_from_user(). David