[PATCH v2] apparmor: fix potential label refcnt leak in aa_change_profile

Markus Elfring Markus.Elfring at web.de
Wed Apr 15 11:27:57 UTC 2020


> According to the comment of aa_get_current_label(), …

I suggest to make this wording clearer.
Would you like to refer to any software documentation here?


> However, when the original object pointed by "label" becomes
> unreachable because aa_change_profile() returns or a new object
> is assigned to "label", reference count increased by
> aa_get_current_label() is not decreased, causing a refcnt leak.

How do you think about to reduce abbreviations in the commit message?

Would you like to add the tag “Fixes” to the change description?

Regards,
Markus



More information about the Linux-security-module-archive mailing list