[PATCH RESEND v11 0/8] proc: modernize proc to support multiple private instances

Eric W. Biederman ebiederm at xmission.com
Thu Apr 9 12:59:47 UTC 2020

Alexey Gladkov <gladkov.alexey at gmail.com> writes:

> Preface:
> --------
> This is patchset v11 to modernize procfs and make it able to support multiple
> private instances per the same pid namespace.
> This patchset can be applied on top of:
> git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git
> 4b871ce26ab2

Why the resend?

Nothing happens until the merge window closes with the release of -rc1
(almost certainly on this coming Sunday).  I goofed and did not act on
this faster, and so it is my fault this did not make it into linux-next
before the merge window.  But I am not going to rush this forward.

You also ignored my review and have not even descibed why it is safe
to change the type of a filesystem parameter.

-	fsparam_u32("hidepid",	Opt_hidepid),
+	fsparam_string("hidepid",	Opt_hidepid),

Especially in light of people using fsconfig(fd, FSCONFIG_SET_...);

All I need is someone to point out that fsparam_u32 does not use

My apologies for being grumpy but this feels like you are asking me to
go faster when it is totally inappropriate to do so, while busily
ignoring my feedback.

I think this should happen.  But I can't do anything until after -rc1.


More information about the Linux-security-module-archive mailing list